Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(component): shortcut style for tooltip #7721

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

CatsJuice
Copy link
Member

@CatsJuice CatsJuice commented Aug 4, 2024

image.png

  • New shortcut prop for <Tooltip />
    • single key
      <Tooltip shortcut="T" />
    • multiple
      <Tooltip shortcut={["⌘",  "K"]} />
  • Round tooltip's arrow
  • Use new design system colors
  • Replace some usage
    • App sidebar switch
    • Editor mode switch
    • New tab (new)

Copy link

graphite-app bot commented Aug 4, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

CatsJuice commented Aug 4, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CatsJuice and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Aug 4, 2024

@CatsJuice CatsJuice marked this pull request as ready for review August 4, 2024 12:34
Copy link

codecov bot commented Aug 4, 2024

Codecov Report

Attention: Patch coverage is 42.10526% with 11 lines in your changes missing coverage. Please review.

Project coverage is 55.38%. Comparing base (3d85564) to head (249f347).

Files Patch % Lines
...ages/frontend/component/src/ui/tooltip/tooltip.tsx 28.57% 4 Missing and 1 partial ⚠️
...s/frontend/component/src/utils/keyboard-mapping.ts 33.33% 4 Missing ⚠️
packages/frontend/component/src/utils/platform.ts 50.00% 0 Missing and 1 partial ⚠️
.../modules/app-tabs-header/views/app-tabs-header.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #7721      +/-   ##
==========================================
- Coverage   55.38%   55.38%   -0.01%     
==========================================
  Files        1000     1002       +2     
  Lines       43365    43384      +19     
  Branches     5176     5181       +5     
==========================================
+ Hits        24019    24028       +9     
- Misses      18987    18995       +8     
- Partials      359      361       +2     
Flag Coverage Δ
server-test 78.91% <ø> (ø)
unittest 26.54% <42.10%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CatsJuice CatsJuice requested a review from pengx17 August 5, 2024 02:01
Copy link

graphite-app bot commented Aug 5, 2024

Merge activity

![image.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/LakojjjzZNf6ogjOVwKE/2e68337c-91f1-4ea7-8426-7fb33be02081.png)

- New `shortcut` prop for `<Tooltip />`
  - single key
      ```tsx
      <Tooltip shortcut="T" />
      ```
  - multiple
      ```tsx
      <Tooltip shortcut={["⌘",  "K"]} />
      ```
- Round tooltip's arrow
- Use new design system colors
- Replace some usage
  - App sidebar switch
  - Editor mode switch
  - New tab (new)
@EYHN EYHN force-pushed the catsjuice/refactor/button branch from 936985f to 3d85564 Compare August 5, 2024 02:57
@EYHN EYHN force-pushed the catsjuice/feat/tooltip-with-shortcut branch from 70c41fb to 249f347 Compare August 5, 2024 02:58
@EYHN EYHN changed the base branch from catsjuice/refactor/button to canary August 5, 2024 03:08
@graphite-app graphite-app bot merged commit 249f347 into canary Aug 5, 2024
33 checks passed
@graphite-app graphite-app bot deleted the catsjuice/feat/tooltip-with-shortcut branch August 5, 2024 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants