Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add tooltip and toast for organize operations #7725

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

CatsJuice
Copy link
Member

@CatsJuice CatsJuice commented Aug 5, 2024

Copy link

graphite-app bot commented Aug 5, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added mod:i18n Related to i18n app:core labels Aug 5, 2024
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CatsJuice and the rest of your teammates on Graphite Graphite

@CatsJuice CatsJuice changed the title feat(core): delete folder toast feat(core): add tooltip and toast for organize operations Aug 5, 2024
Copy link

nx-cloud bot commented Aug 5, 2024

@CatsJuice CatsJuice marked this pull request as ready for review August 5, 2024 03:59
@graphite-app graphite-app bot requested review from forehalo, pengx17, JimmFly and EYHN and removed request for forehalo August 5, 2024 03:59
Copy link

codecov bot commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 26.50%. Comparing base (cd4e462) to head (5938d8b).

Files Patch % Lines
.../src/modules/explorer/views/nodes/folder/index.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           canary    #7725       +/-   ##
===========================================
- Coverage   55.27%   26.50%   -28.78%     
===========================================
  Files        1006      798      -208     
  Lines       43444    19575    -23869     
  Branches     5197     3645     -1552     
===========================================
- Hits        24015     5188    -18827     
+ Misses      19064    14078     -4986     
+ Partials      365      309       -56     
Flag Coverage Δ
server-test ?
unittest 26.50% <50.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CatsJuice CatsJuice force-pushed the catsjuice/feat/organize-tip-and-toast branch from bab7977 to 4901d9b Compare August 5, 2024 07:51
Copy link

graphite-app bot commented Aug 5, 2024

Merge activity

  • Aug 5, 9:56 AM EDT: EYHN added this pull request to the Graphite merge queue.
  • Aug 5, 10:08 AM EDT: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: '3, 2, 1 Launch', 'Server Test').
  • Aug 5, 10:06 PM EDT: EYHN added this pull request to the Graphite merge queue.
  • Aug 5, 10:19 PM EDT: EYHN merged this pull request with the Graphite merge queue.

@EYHN EYHN force-pushed the catsjuice/feat/organize-tip-and-toast branch from 4901d9b to a450703 Compare August 5, 2024 13:57
@EYHN EYHN force-pushed the catsjuice/feat/organize-tip-and-toast branch from a450703 to 5938d8b Compare August 6, 2024 02:07
@graphite-app graphite-app bot merged commit 5938d8b into canary Aug 6, 2024
34 checks passed
@graphite-app graphite-app bot deleted the catsjuice/feat/organize-tip-and-toast branch August 6, 2024 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core mod:i18n Related to i18n
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants