-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): add favorite folder in menu, adjust empty-page new page button #7730
Conversation
Your org has enabled the Graphite merge queue for merging into canaryAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @CatsJuice and the rest of your teammates on Graphite |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 6d253c0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## canary #7730 +/- ##
===========================================
- Coverage 55.34% 26.51% -28.83%
===========================================
Files 1005 798 -207
Lines 43436 19555 -23881
Branches 5190 3642 -1548
===========================================
- Hits 24038 5185 -18853
+ Misses 19036 14061 -4975
+ Partials 362 309 -53
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
3d4d06d
to
d40fb7a
Compare
Merge activity
|
…tton (#7730) close AF-1150, AF-1128, AF-1131 - Replace favorite migration related copy - Adjust empty page's "New Page" button ![CleanShot 2024-08-05 at 15.16.06@2x.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/LakojjjzZNf6ogjOVwKE/1cf7d75a-a33a-4eec-9dc1-87d50d9526f1.png) - Add toggle favorite to folder menu ![CleanShot 2024-08-05 at 15.17.50@2x.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/LakojjjzZNf6ogjOVwKE/af6116b5-47d1-49a6-9660-41c0d7cd8fd3.png) - Adjust `Button` - add `withoutHover` state - remove cursor: not-allowed when disabled
d40fb7a
to
6d253c0
Compare
close AF-1150, AF-1128, AF-1131
Button
withoutHover
state