Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): add favorite folder in menu, adjust empty-page new page button #7730

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

CatsJuice
Copy link
Member

@CatsJuice CatsJuice commented Aug 5, 2024

close AF-1150, AF-1128, AF-1131

  • Replace favorite migration related copy
  • Adjust empty page's "New Page" button
    CleanShot 2024-08-05 at 15.16.06@2x.png
  • Add toggle favorite to folder menu
    CleanShot 2024-08-05 at 15.17.50@2x.png
  • Adjust Button
    • add withoutHover state
    • remove cursor: not-allowed when disabled

Copy link

graphite-app bot commented Aug 5, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CatsJuice and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Aug 5, 2024

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 7.14286% with 13 lines in your changes missing coverage. Please review.

Project coverage is 26.51%. Comparing base (73a6723) to head (6d253c0).

Files Patch % Lines
...modules/explorer/views/nodes/folder/operations.tsx 12.50% 7 Missing ⚠️
...nd/core/src/modules/properties/services/adapter.ts 0.00% 4 Missing ⚠️
...ckages/frontend/component/src/ui/button/button.tsx 0.00% 1 Missing ⚠️
.../src/modules/explorer/views/nodes/folder/index.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           canary    #7730       +/-   ##
===========================================
- Coverage   55.34%   26.51%   -28.83%     
===========================================
  Files        1005      798      -207     
  Lines       43436    19555    -23881     
  Branches     5190     3642     -1548     
===========================================
- Hits        24038     5185    -18853     
+ Misses      19036    14061     -4975     
+ Partials      362      309       -53     
Flag Coverage Δ
server-test ?
unittest 26.51% <7.14%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CatsJuice CatsJuice marked this pull request as ready for review August 5, 2024 07:21
Copy link

graphite-app bot commented Aug 5, 2024

Merge activity

…tton (#7730)

close AF-1150, AF-1128, AF-1131
- Replace favorite migration related copy
- Adjust empty page's "New Page" button
  ![CleanShot 2024-08-05 at 15.16.06@2x.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/LakojjjzZNf6ogjOVwKE/1cf7d75a-a33a-4eec-9dc1-87d50d9526f1.png)
- Add toggle favorite to folder menu
  ![CleanShot 2024-08-05 at 15.17.50@2x.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/LakojjjzZNf6ogjOVwKE/af6116b5-47d1-49a6-9660-41c0d7cd8fd3.png)
- Adjust `Button`
  - add `withoutHover` state
  - remove cursor: not-allowed when disabled
@forehalo forehalo force-pushed the catsjuice/fix/0805-explorer branch from d40fb7a to 6d253c0 Compare August 5, 2024 09:15
@graphite-app graphite-app bot merged commit 6d253c0 into canary Aug 5, 2024
34 checks passed
@graphite-app graphite-app bot deleted the catsjuice/fix/0805-explorer branch August 5, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants