Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(electron): app ghosting issue when quickly opening new tabs #7736

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Aug 5, 2024

fix PD-1519

Copy link

graphite-app bot commented Aug 5, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Collaborator Author

pengx17 commented Aug 5, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pengx17 and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the app:electron Related to electron app label Aug 5, 2024
@pengx17 pengx17 force-pushed the xp/08-05-fix_electron_app_ghosting_issue_when_quickly_opening_new_tabs branch from 64dc3e2 to ecec629 Compare August 5, 2024 08:22
Copy link

nx-cloud bot commented Aug 5, 2024

@pengx17 pengx17 marked this pull request as ready for review August 5, 2024 08:26
Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.59%. Comparing base (5ab1210) to head (5050418).

Additional details and impacted files
@@             Coverage Diff             @@
##           canary    #7736       +/-   ##
===========================================
- Coverage   55.37%   26.59%   -28.78%     
===========================================
  Files        1005      797      -208     
  Lines       43435    19544    -23891     
  Branches     5190     3637     -1553     
===========================================
- Hits        24052     5198    -18854     
+ Misses      19018    14034     -4984     
+ Partials      365      312       -53     
Flag Coverage Δ
server-test ?
unittest 26.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Aug 5, 2024

Merge activity

@forehalo forehalo force-pushed the xp/08-05-fix_electron_app_ghosting_issue_when_quickly_opening_new_tabs branch from ecec629 to 5050418 Compare August 5, 2024 08:51
@graphite-app graphite-app bot merged commit 5050418 into canary Aug 5, 2024
33 checks passed
@graphite-app graphite-app bot deleted the xp/08-05-fix_electron_app_ghosting_issue_when_quickly_opening_new_tabs branch August 5, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:electron Related to electron app
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants