Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(electron): reduce the number of listeners for ipc #7740

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Aug 5, 2024

previously there are quite a lot of api/events handlers registered on ipcMain/ipcRenderer. After this PR, the number should be significantly reduced, which will benefit performance.

Copy link

graphite-app bot commented Aug 5, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@pengx17 pengx17 marked this pull request as ready for review August 5, 2024 10:44
@github-actions github-actions bot added the app:electron Related to electron app label Aug 5, 2024
@graphite-app graphite-app bot requested review from CatsJuice, JimmFly, forehalo and EYHN and removed request for CatsJuice August 5, 2024 10:45
Copy link
Collaborator Author

pengx17 commented Aug 5, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pengx17 and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Aug 5, 2024

@pengx17 pengx17 requested a review from CatsJuice August 5, 2024 10:47
@pengx17 pengx17 changed the title refactor(electron): reduce the number of listeners for ipcmain refactor(electron): reduce the number of listeners for ipc Aug 5, 2024
Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.30%. Comparing base (0acc1bd) to head (0d7de67).

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #7740      +/-   ##
==========================================
+ Coverage   55.26%   55.30%   +0.04%     
==========================================
  Files        1006     1006              
  Lines       43428    43428              
  Branches     5194     5195       +1     
==========================================
+ Hits        24001    24019      +18     
+ Misses      19065    19047      -18     
  Partials      362      362              
Flag Coverage Δ
server-test 78.88% <ø> (+0.07%) ⬆️
unittest 26.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Aug 5, 2024

Merge activity

previously there are quite a lot of api/events handlers registered on ipcMain/ipcRenderer. After this PR, the number should be significantly reduced, which will benefit performance.
@EYHN EYHN force-pushed the xp/08-05-refactor_electron_reduce_the_number_of_listeners_for_ipcmain branch from c4e431f to 0d7de67 Compare August 5, 2024 13:33
@graphite-app graphite-app bot merged commit 0d7de67 into canary Aug 5, 2024
33 checks passed
@graphite-app graphite-app bot deleted the xp/08-05-refactor_electron_reduce_the_number_of_listeners_for_ipcmain branch August 5, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:electron Related to electron app
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants