Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): remove old favorite #7743

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Conversation

EYHN
Copy link
Member

@EYHN EYHN commented Aug 5, 2024

closes AF-1203

@EYHN EYHN marked this pull request as ready for review August 5, 2024 14:14
Copy link

graphite-app bot commented Aug 5, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

EYHN commented Aug 5, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @EYHN and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Aug 5, 2024

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 4.76190% with 20 lines in your changes missing coverage. Please review.

Project coverage is 26.80%. Comparing base (c2cf331) to head (dd74cfe).

Files Patch % Lines
...nd/core/src/modules/properties/services/adapter.ts 0.00% 8 Missing ⚠️
.../core/src/components/page-list/tags/select-tag.tsx 12.50% 7 Missing ⚠️
...rc/modules/explorer/views/nodes/tag/operations.tsx 0.00% 2 Missing ⚠️
...onents/page-list/collections/select-collection.tsx 0.00% 1 Missing ⚠️
...d/core/src/components/page-list/operation-cell.tsx 0.00% 1 Missing ⚠️
.../src/modules/explorer/views/nodes/folder/index.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           canary    #7743       +/-   ##
===========================================
- Coverage   55.45%   26.80%   -28.66%     
===========================================
  Files        1001      790      -211     
  Lines       43325    19327    -23998     
  Branches     5168     3577     -1591     
===========================================
- Hits        24028     5181    -18847     
+ Misses      18929    13831     -5098     
+ Partials      368      315       -53     
Flag Coverage Δ
server-test ?
unittest 26.80% <4.76%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Aug 7, 2024

Merge activity

@EYHN EYHN force-pushed the eyhn/chore/remove-old-fav branch from feedcd7 to dd74cfe Compare August 7, 2024 02:19
@graphite-app graphite-app bot merged commit dd74cfe into canary Aug 7, 2024
33 checks passed
@graphite-app graphite-app bot deleted the eyhn/chore/remove-old-fav branch August 7, 2024 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants