Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: tracking events for app tabs header #7778

Merged

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Aug 7, 2024

fix AF-1194

Copy link

graphite-app bot commented Aug 7, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Collaborator Author

pengx17 commented Aug 7, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pengx17 and the rest of your teammates on Graphite Graphite

@pengx17 pengx17 marked this pull request as ready for review August 7, 2024 11:09
Copy link

nx-cloud bot commented Aug 7, 2024

@pengx17 pengx17 force-pushed the 08-07-chore_tracking_events_for_app_tabs_header branch from aa53f6b to 3298e1e Compare August 7, 2024 11:12
@github-actions github-actions bot added the app:electron Related to electron app label Aug 7, 2024
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.75%. Comparing base (6ef5675) to head (b71945c).

Additional details and impacted files
@@             Coverage Diff             @@
##           canary    #7778       +/-   ##
===========================================
- Coverage   55.54%   26.75%   -28.79%     
===========================================
  Files        1002      793      -209     
  Lines       43396    19378    -24018     
  Branches     5146     3587     -1559     
===========================================
- Hits        24103     5185    -18918     
+ Misses      18929    13882     -5047     
+ Partials      364      311       -53     
Flag Coverage Δ
server-test ?
unittest 26.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pengx17 pengx17 force-pushed the 08-07-chore_tracking_events_for_app_tabs_header branch 2 times, most recently from cd86655 to bcbc006 Compare August 8, 2024 05:01
Copy link

graphite-app bot commented Aug 8, 2024

Merge activity

  • Aug 8, 3:00 AM EDT: pengx17 added this pull request to the Graphite merge queue.
  • Aug 8, 3:13 AM EDT: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: '3, 2, 1 Launch', 'Desktop Test (windows-latest, windows, x64, x86_64-pc-windows-msvc, true)').
  • Aug 8, 4:30 AM EDT: pengx17 added this pull request to the Graphite merge queue.
  • Aug 8, 5:27 AM EDT: pengx17 merged this pull request with the Graphite merge queue.

pengx17 added a commit that referenced this pull request Aug 8, 2024
@pengx17 pengx17 force-pushed the 08-07-chore_tracking_events_for_app_tabs_header branch from bcbc006 to c96bf24 Compare August 8, 2024 07:02
pengx17 added a commit that referenced this pull request Aug 8, 2024
@pengx17 pengx17 force-pushed the 08-07-chore_tracking_events_for_app_tabs_header branch from c96bf24 to 02bcbad Compare August 8, 2024 09:11
pengx17 added a commit that referenced this pull request Aug 8, 2024
@pengx17 pengx17 force-pushed the 08-07-chore_tracking_events_for_app_tabs_header branch from 02bcbad to 0fcfbfa Compare August 8, 2024 09:13
@pengx17 pengx17 force-pushed the 08-07-chore_tracking_events_for_app_tabs_header branch from 0fcfbfa to b71945c Compare August 8, 2024 09:14
@graphite-app graphite-app bot merged commit b71945c into canary Aug 8, 2024
33 checks passed
@graphite-app graphite-app bot deleted the 08-07-chore_tracking_events_for_app_tabs_header branch August 8, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core app:electron Related to electron app
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants