-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): can not get chrome version in desktop mode in iOS #7791
Conversation
Your org has enabled the Graphite merge queue for merging into canaryAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 509ded0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## canary #7791 +/- ##
==========================================
- Coverage 55.58% 55.53% -0.05%
==========================================
Files 1003 1003
Lines 43397 43401 +4
Branches 5147 5148 +1
==========================================
- Hits 24122 24103 -19
- Misses 18911 18934 +23
Partials 364 364
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
a0ea678
to
6abaf4d
Compare
Merge activity
|
When set iOS chrome to desktop mode, the ua will be like: ``` Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) CriOS/127 Version/11.1.1 Safari/605.1.15 ``` The `CriOS/127` can not be tested by the following code, which make app crash https://github.com/toeverything/AFFiNE/blob/fd6e19829550d983cb4a3640f05a8dd8f50c92b6/packages/common/env/src/ua-helper.ts#L14-L18
6abaf4d
to
509ded0
Compare
When set iOS chrome to desktop mode, the ua will be like:
The
CriOS/127
can not be tested by the following code, which make app crashAFFiNE/packages/common/env/src/ua-helper.ts
Lines 14 to 18 in fd6e198