Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(component): add autoFocusConfirmButton for confirm-modal #7801

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

CatsJuice
Copy link
Member

@CatsJuice CatsJuice commented Aug 9, 2024

close #5813

🎥 Video uploaded on Graphite:

Copy link

graphite-app bot commented Aug 9, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CatsJuice and the rest of your teammates on Graphite Graphite

@CatsJuice CatsJuice marked this pull request as ready for review August 9, 2024 03:27
Copy link

nx-cloud bot commented Aug 9, 2024

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

Attention: Patch coverage is 6.25000% with 30 lines in your changes missing coverage. Please review.

Project coverage is 26.72%. Comparing base (b2c00a2) to head (26fd9a4).

Files Patch % Lines
...s/frontend/component/src/hooks/focus-and-select.ts 15.38% 11 Missing ⚠️
packages/frontend/component/src/ui/input/input.tsx 0.00% 11 Missing ⚠️
...ckages/frontend/component/src/ui/button/button.tsx 0.00% 7 Missing ⚠️
.../frontend/component/src/ui/modal/confirm-modal.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           canary    #7801       +/-   ##
===========================================
- Coverage   55.57%   26.72%   -28.85%     
===========================================
  Files        1003      795      -208     
  Lines       43403    19403    -24000     
  Branches     5149     3592     -1557     
===========================================
- Hits        24121     5186    -18935     
+ Misses      18918    13906     -5012     
+ Partials      364      311       -53     
Flag Coverage Δ
server-test ?
unittest 26.72% <6.25%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@forehalo forehalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modal of creating workspace manually handled onPress('enter'). it should be replaced

Copy link

graphite-app bot commented Aug 9, 2024

Merge activity

@EYHN EYHN force-pushed the catjuice/feat/auto-focus-confirm-modal-button branch from 522ff2b to 26fd9a4 Compare August 9, 2024 05:50
@graphite-app graphite-app bot merged commit 26fd9a4 into canary Aug 9, 2024
33 checks passed
@graphite-app graphite-app bot deleted the catjuice/feat/auto-focus-confirm-modal-button branch August 9, 2024 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Auto focus the delete confirm button
4 participants