Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(electron): missing collection name in tab header #7807

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Aug 9, 2024

fix AF-1177

Copy link

graphite-app bot commented Aug 9, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Collaborator Author

pengx17 commented Aug 9, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pengx17 and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Aug 9, 2024

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.79%. Comparing base (009b535) to head (fc19180).

Additional details and impacted files
@@                                        Coverage Diff                                        @@
##           xp/08-09-fix_electron_shell_should_import_renderer_css_in_dev    #7807      +/-   ##
=================================================================================================
+ Coverage                                                          26.72%   26.79%   +0.06%     
=================================================================================================
  Files                                                                795      795              
  Lines                                                              19404    19404              
  Branches                                                            3592     3592              
=================================================================================================
+ Hits                                                                5186     5199      +13     
+ Misses                                                             13907    13891      -16     
- Partials                                                             311      314       +3     
Flag Coverage Δ
unittest 26.79% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pengx17 pengx17 marked this pull request as ready for review August 9, 2024 06:40
Copy link

graphite-app bot commented Aug 9, 2024

Merge activity

@pengx17 pengx17 force-pushed the xp/08-09-fix_electron_shell_should_import_renderer_css_in_dev branch from 1827583 to 009b535 Compare August 9, 2024 07:02
@pengx17 pengx17 force-pushed the xp/08-09-fix_electron_missing_collection_name_in_tab_header branch from 4aeafc3 to fc19180 Compare August 9, 2024 07:03
Base automatically changed from xp/08-09-fix_electron_shell_should_import_renderer_css_in_dev to canary August 9, 2024 07:14
@graphite-app graphite-app bot merged commit fc19180 into canary Aug 9, 2024
33 checks passed
@graphite-app graphite-app bot deleted the xp/08-09-fix_electron_missing_collection_name_in_tab_header branch August 9, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants