Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(electron): app got deleted when auto update on windows #7820

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

forehalo
Copy link
Member

@forehalo forehalo commented Aug 9, 2024

No description provided.

@graphite-app graphite-app bot requested review from CatsJuice, EYHN and pengx17 and removed request for CatsJuice August 9, 2024 10:58
Copy link

graphite-app bot commented Aug 9, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@graphite-app graphite-app bot requested a review from JimmFly August 9, 2024 10:58
Copy link
Member Author

forehalo commented Aug 9, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @forehalo and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the app:electron Related to electron app label Aug 9, 2024
Copy link

nx-cloud bot commented Aug 9, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 229725a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 4 targets

Sent with 💌 from NxCloud.

@forehalo forehalo force-pushed the 61/fix-windows-installer branch 2 times, most recently from fac4343 to 70af735 Compare August 9, 2024 11:01
pengx17
pengx17 previously approved these changes Aug 9, 2024
Copy link
Collaborator

@pengx17 pengx17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's try make it to canary and tested asap

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 55.51%. Comparing base (eef9afd) to head (229725a).
Report is 7 commits behind head on canary.

Files Patch % Lines
...ckages/frontend/electron/src/main/updater/utils.ts 16.66% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           canary    #7820   +/-   ##
=======================================
  Coverage   55.50%   55.51%           
=======================================
  Files        1004     1005    +1     
  Lines       43426    43444   +18     
  Branches     5153     5157    +4     
=======================================
+ Hits        24105    24116   +11     
- Misses      18957    18962    +5     
- Partials      364      366    +2     
Flag Coverage Δ
server-test 78.76% <ø> (ø)
unittest 26.75% <16.66%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pengx17 pengx17 dismissed their stale review August 9, 2024 13:45

not working yet

Copy link

graphite-app bot commented Aug 13, 2024

Merge activity

@forehalo forehalo merged commit 83a9bee into canary Aug 13, 2024
43 checks passed
@forehalo forehalo deleted the 61/fix-windows-installer branch August 13, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:electron Related to electron app
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants