Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): init editor setting ui #7878

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Conversation

JimmFly
Copy link
Member

@JimmFly JimmFly commented Aug 14, 2024

  • init editor setting ui
CleanShot.2024-08-14.at.23.15.13.mp4

Copy link
Member Author

JimmFly commented Aug 14, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JimmFly and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Aug 14, 2024

@JimmFly JimmFly changed the title feat(component): add slider ui component feat(core): init editor setting ui Aug 14, 2024
@JimmFly JimmFly marked this pull request as ready for review August 14, 2024 15:22
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.21%. Comparing base (03c4d56) to head (b333cde).
Report is 2 commits behind head on canary.

Additional details and impacted files
@@           Coverage Diff           @@
##           canary    #7878   +/-   ##
=======================================
  Coverage   55.21%   55.21%           
=======================================
  Files        1051     1051           
  Lines       44643    44643           
  Branches     5259     5259           
=======================================
  Hits        24651    24651           
  Misses      19614    19614           
  Partials      378      378           
Flag Coverage Δ
server-test 77.60% <ø> (ø)
unittest 27.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Aug 14, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@JimmFly JimmFly force-pushed the jimmfly/0814/editor-setting branch from 05578f8 to ad1ca86 Compare August 14, 2024 15:40
@JimmFly JimmFly changed the base branch from canary to jimmfly/0814/add-slider-ui August 15, 2024 02:26
@JimmFly JimmFly force-pushed the jimmfly/0814/editor-setting branch from ad1ca86 to a9f337d Compare August 15, 2024 06:25
@JimmFly JimmFly requested a review from pengx17 August 15, 2024 06:27
@github-actions github-actions bot added the mod:infra Environment related issues and discussions label Aug 21, 2024
@JimmFly JimmFly force-pushed the jimmfly/0814/editor-setting branch from 5af885b to 93ad9ca Compare August 21, 2024 07:36
Copy link

graphite-app bot commented Aug 21, 2024

Merge activity

@JimmFly JimmFly force-pushed the jimmfly/0814/editor-setting branch from 83aea6e to b333cde Compare August 22, 2024 04:25
Base automatically changed from jimmfly/0814/add-slider-ui to canary August 22, 2024 04:36
@graphite-app graphite-app bot merged commit b333cde into canary Aug 22, 2024
33 checks passed
@graphite-app graphite-app bot deleted the jimmfly/0814/editor-setting branch August 22, 2024 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core mod:component mod:dev mod:env mod:i18n Related to i18n mod:infra Environment related issues and discussions
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

4 participants