Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): improve scroll anchoring #8132

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

fundon
Copy link
Contributor

@fundon fundon commented Sep 6, 2024

Upstreams: toeverything/blocksuite#8335

  • set padding to [20,20,100,20]
  • cancel smooth movement and scaling
  • focus and zoom in on elements/blocks

Copy link

graphite-app bot commented Sep 6, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

fundon commented Sep 6, 2024

Copy link

nx-cloud bot commented Sep 6, 2024

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.70%. Comparing base (d2bd39a) to head (d2cb7b7).
Report is 1 commits behind head on canary.

Additional details and impacted files
@@           Coverage Diff           @@
##           canary    #8132   +/-   ##
=======================================
  Coverage   72.70%   72.70%           
=======================================
  Files         519      519           
  Lines       32781    32781           
  Branches     2967     2967           
=======================================
  Hits        23833    23833           
  Misses       8911     8911           
  Partials       37       37           
Flag Coverage Δ
server-test 78.86% <ø> (ø)
unittest 49.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fundon fundon changed the base branch from fundon/09_06_inlineEditor_on_rich-text_may_be_null to graphite-base/8132 September 6, 2024 03:50
@fundon fundon force-pushed the fundon/09_06_improve_scroll_anchoring branch from 5ebcf0e to 1d96183 Compare September 6, 2024 04:01
@fundon fundon changed the base branch from graphite-base/8132 to canary September 6, 2024 04:02
@fundon fundon force-pushed the fundon/09_06_improve_scroll_anchoring branch from 1d96183 to 3352b32 Compare September 6, 2024 04:02
@fundon fundon force-pushed the fundon/09_06_improve_scroll_anchoring branch from 3352b32 to 2c0569b Compare September 12, 2024 23:05
@fundon fundon marked this pull request as ready for review September 12, 2024 23:07
@graphite-app graphite-app bot requested review from JimmFly, EYHN, CatsJuice, forehalo and pengx17 and removed request for JimmFly September 12, 2024 23:07
Copy link

graphite-app bot commented Sep 13, 2024

Merge activity

Upstreams: toeverything/blocksuite#8335
* set `padding` to `[20,20,100,20]`
* cancel smooth movement and scaling
* focus and zoom in on elements/blocks
@fundon fundon force-pushed the fundon/09_06_improve_scroll_anchoring branch from e53db9b to d2cb7b7 Compare September 13, 2024 13:13
@graphite-app graphite-app bot merged commit d2cb7b7 into canary Sep 13, 2024
38 checks passed
@graphite-app graphite-app bot deleted the fundon/09_06_improve_scroll_anchoring branch September 13, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants