Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(electron): do not always enable devtools detach mode #8273

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Sep 18, 2024

No description provided.

Copy link

graphite-app bot commented Sep 18, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Collaborator Author

pengx17 commented Sep 18, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pengx17 and the rest of your teammates on Graphite Graphite

@pengx17 pengx17 marked this pull request as ready for review September 18, 2024 02:28
@github-actions github-actions bot added the app:electron Related to electron app label Sep 18, 2024
Copy link

nx-cloud bot commented Sep 18, 2024

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.64%. Comparing base (714b7b8) to head (7a26c76).
Report is 1 commits behind head on canary.

Additional details and impacted files
@@           Coverage Diff           @@
##           canary    #8273   +/-   ##
=======================================
  Coverage   72.64%   72.64%           
=======================================
  Files         519      519           
  Lines       32781    32781           
  Branches     2966     2966           
=======================================
  Hits        23815    23815           
  Misses       8929     8929           
  Partials       37       37           
Flag Coverage Δ
server-test 78.79% <ø> (ø)
unittest 49.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Sep 18, 2024

Merge activity

@forehalo forehalo force-pushed the 09-18-fix_electron_do_not_always_enable_devtools_detach_mode branch from aa27601 to 7a26c76 Compare September 18, 2024 04:17
@graphite-app graphite-app bot merged commit 7a26c76 into canary Sep 18, 2024
38 checks passed
@graphite-app graphite-app bot deleted the 09-18-fix_electron_do_not_always_enable_devtools_detach_mode branch September 18, 2024 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:electron Related to electron app
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants