Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): emoji as doc icon support with feature flag #8348

Open
wants to merge 1 commit into
base: canary
Choose a base branch
from

Conversation

CatsJuice
Copy link
Member

@CatsJuice CatsJuice commented Sep 23, 2024

close AF-1412

Adjusted the priority of the public doc icon:

  1. block-reference
  2. journal
  3. page reference
  4. emoji (*new)
  5. default

Copy link

graphite-app bot commented Sep 23, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added mod:infra Environment related issues and discussions app:core labels Sep 23, 2024
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CatsJuice and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Sep 23, 2024

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.77%. Comparing base (d0f04d2) to head (978d671).

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #8348      +/-   ##
==========================================
+ Coverage   72.71%   72.77%   +0.05%     
==========================================
  Files         519      519              
  Lines       32900    32900              
  Branches     2866     2866              
==========================================
+ Hits        23924    23942      +18     
+ Misses       8945     8927      -18     
  Partials       31       31              
Flag Coverage Δ
server-test 78.95% <ø> (+0.06%) ⬆️
unittest 49.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CatsJuice CatsJuice marked this pull request as ready for review September 23, 2024 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core mod:infra Environment related issues and discussions
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant