Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): set doc mode and primary doc mode separately #8359

Open
wants to merge 3 commits into
base: canary
Choose a base branch
from

Conversation

JimmFly
Copy link
Member

@JimmFly JimmFly commented Sep 23, 2024

CleanShot.2024-09-24.at.01.41.30.mp4

Copy link
Member Author

JimmFly commented Sep 23, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JimmFly and the rest of your teammates on Graphite Graphite

Copy link

graphite-app bot commented Sep 23, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link

nx-cloud bot commented Sep 23, 2024

@JimmFly JimmFly marked this pull request as ready for review September 23, 2024 17:35
@github-actions github-actions bot added mod:i18n Related to i18n app:core labels Sep 23, 2024
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.26%. Comparing base (4e30f75) to head (309c622).

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #8359      +/-   ##
==========================================
+ Coverage   70.21%   70.26%   +0.05%     
==========================================
  Files         520      520              
  Lines       32961    32961              
  Branches     2879     2879              
==========================================
+ Hits        23142    23160      +18     
+ Misses       9481     9463      -18     
  Partials      338      338              
Flag Coverage Δ
server-test 76.78% <ø> (+0.06%) ⬆️
unittest 46.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the test Related to test cases label Sep 23, 2024
@JimmFly JimmFly force-pushed the jimmfly/0924/view-mode branch 4 times, most recently from 7400d45 to 266a4a9 Compare September 24, 2024 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core mod:i18n Related to i18n test Related to test cases
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants