Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): show floating sidebar when hovering sidebar swtich #8393

Open
wants to merge 1 commit into
base: canary
Choose a base branch
from

Conversation

JimmFly
Copy link
Member

@JimmFly JimmFly commented Sep 25, 2024

web:

CleanShot.2024-09-26.at.17.23.44.mp4

client:

CleanShot.2024-09-26.at.17.39.37.mp4

Copy link

graphite-app bot commented Sep 25, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@JimmFly JimmFly marked this pull request as ready for review September 25, 2024 18:31
Copy link
Member Author

JimmFly commented Sep 25, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JimmFly and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Sep 25, 2024

@JimmFly JimmFly force-pushed the jimmfly/0925/refactor-sidebar branch from d43d154 to 17182fc Compare September 25, 2024 18:45
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.21%. Comparing base (e1fda02) to head (8f7577f).

Additional details and impacted files
@@                  Coverage Diff                   @@
##           graphite-base/8393    #8393      +/-   ##
======================================================
- Coverage               76.71%   70.21%   -6.51%     
======================================================
  Files                     228      520     +292     
  Lines                   25974    32961    +6987     
  Branches                 1480     2879    +1399     
======================================================
+ Hits                    19926    23142    +3216     
- Misses                   5991     9481    +3490     
- Partials                   57      338     +281     
Flag Coverage Δ
server-test 76.71% <ø> (ø)
unittest 46.02% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

perfsee bot commented Sep 26, 2024

affine-toeverything

Bundle main

diff ------------------- Bundle Size Diff -------------------------

@@                        EntryPoint: app                        @@
##                     canary …/tags/v0.17.2                 +/- ##
===================================================================
< Bundle              21.7 MB        23.1 MB    +1.43 MB(+6.61%)   
< Initial JS            10 MB        10.3 MB     +243 kB(+2.43%)   
> Initial CSS          239 kB         225 kB    -13.9 kB(-5.84%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
< Assets                   57             65                  +8   
< Chunks                   55             63                  +8   
< Packages                299            302                  +3   
= Duplicates               23             23                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              
! Avoid cache wasting                                              

@EYHN EYHN changed the base branch from jimmfly/0925/refactor-sidebar to graphite-base/8393 September 26, 2024 16:54
@JimmFly JimmFly force-pushed the jimmfly/0926/floating-sidebar branch from 86a756c to 8f7577f Compare September 27, 2024 02:49
Copy link

graphite-app bot commented Sep 27, 2024

Merge activity

@EYHN EYHN force-pushed the jimmfly/0926/floating-sidebar branch from 8f7577f to bd85d94 Compare September 27, 2024 09:33
@EYHN EYHN changed the base branch from graphite-base/8393 to jimmfly/0925/refactor-sidebar September 27, 2024 09:33
Base automatically changed from jimmfly/0925/refactor-sidebar to canary September 27, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants