Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(inline): spell checker itself will delete text #7764

Merged
merged 1 commit into from
Jul 30, 2024
Merged

fix(inline): spell checker itself will delete text #7764

merged 1 commit into from
Jul 30, 2024

Conversation

fourdim
Copy link
Contributor

@fourdim fourdim commented Jul 30, 2024 •
edited
Loading

This closes BS-897

@vercel Vercel
Copy link

vercel bot commented Jul 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 30, 2024 5:13am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Jul 30, 2024 5:13am

@graphite-app Graphite App
Copy link

graphite-app bot commented Jul 30, 2024

Your org has enabled the Graphite merge queue for merging into master

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@fourdim Graphite App
Copy link
Contributor Author

fourdim commented Jul 30, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @fourdim and the rest of your teammates on Graphite Graphite

@fourdim fourdim requested a review from Flrande July 30, 2024 03:50
@fourdim fourdim marked this pull request as ready for review July 30, 2024 03:50
@fourdim fourdim changed the title fix(inline): skpell checker itself will delete text fix(inline): spell checker itself will delete text Jul 30, 2024
@fourdim fourdim temporarily deployed to Playground E2E Test July 30, 2024 03:54 — with GitHub Actions Inactive
@fourdim fourdim temporarily deployed to Playground E2E Test July 30, 2024 03:54 — with GitHub Actions Inactive
@fourdim fourdim temporarily deployed to Playground E2E Test July 30, 2024 03:54 — with GitHub Actions Inactive
@fourdim fourdim temporarily deployed to Playground E2E Test July 30, 2024 03:54 — with GitHub Actions Inactive
@fourdim fourdim temporarily deployed to Playground E2E Test July 30, 2024 03:54 — with GitHub Actions Inactive
@fourdim fourdim temporarily deployed to Playground E2E Test July 30, 2024 03:54 — with GitHub Actions Inactive
@fourdim fourdim temporarily deployed to Playground E2E Test July 30, 2024 03:54 — with GitHub Actions Inactive
@fourdim fourdim temporarily deployed to Playground E2E Test July 30, 2024 03:54 — with GitHub Actions Inactive
@fourdim fourdim temporarily deployed to Playground E2E Test July 30, 2024 03:54 — with GitHub Actions Inactive
@fourdim fourdim temporarily deployed to Playground E2E Test July 30, 2024 03:54 — with GitHub Actions Inactive
@Flrande Flrande added the merge label Jul 30, 2024
@graphite-app Graphite App
Copy link

graphite-app bot commented Jul 30, 2024 •
edited
Loading

Merge activity

  • Jul 30, 12:45 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jul 30, 12:46 AM EDT: Flrande added this pull request to the Graphite merge queue.
  • Jul 30, 1:28 AM EDT: Flrande merged this pull request with the Graphite merge queue.

@Flrande Flrande force-pushed the 07-29-fix_inline_skpell_checker_itself_will_delete_text branch from a4b9687 to b5e0844 Compare July 30, 2024 05:11
@Flrande Flrande temporarily deployed to Playground E2E Test July 30, 2024 05:18 — with GitHub Actions Inactive
@Flrande Flrande temporarily deployed to Playground E2E Test July 30, 2024 05:18 — with GitHub Actions Inactive
@Flrande Flrande temporarily deployed to Playground E2E Test July 30, 2024 05:18 — with GitHub Actions Inactive
@Flrande Flrande temporarily deployed to Playground E2E Test July 30, 2024 05:18 — with GitHub Actions Inactive
@Flrande Flrande temporarily deployed to Playground E2E Test July 30, 2024 05:18 — with GitHub Actions Inactive
@Flrande Flrande temporarily deployed to Playground E2E Test July 30, 2024 05:18 — with GitHub Actions Inactive
@Flrande Flrande temporarily deployed to Playground E2E Test July 30, 2024 05:18 — with GitHub Actions Inactive
@Flrande Flrande temporarily deployed to Playground E2E Test July 30, 2024 05:18 — with GitHub Actions Inactive
@Flrande Flrande temporarily deployed to Playground E2E Test July 30, 2024 05:18 — with GitHub Actions Inactive
@Flrande Flrande temporarily deployed to Playground E2E Test July 30, 2024 05:18 — with GitHub Actions Inactive
@graphite-app graphite-app bot merged commit b5e0844 into master Jul 30, 2024
19 checks passed
@graphite-app graphite-app bot deleted the 07-29-fix_inline_skpell_checker_itself_will_delete_text branch July 30, 2024 05:28
@graphite-app graphite-app bot temporarily deployed to Playground E2E Test July 30, 2024 05:35 Inactive
@graphite-app graphite-app bot temporarily deployed to Playground E2E Test July 30, 2024 05:36 Inactive
@graphite-app graphite-app bot temporarily deployed to Playground E2E Test July 30, 2024 05:36 Inactive
@graphite-app graphite-app bot temporarily deployed to Playground E2E Test July 30, 2024 05:36 Inactive
@graphite-app graphite-app bot temporarily deployed to Playground E2E Test July 30, 2024 05:36 Inactive
@graphite-app graphite-app bot temporarily deployed to Playground E2E Test July 30, 2024 05:36 Inactive
@graphite-app graphite-app bot temporarily deployed to Playground E2E Test July 30, 2024 05:36 Inactive
@graphite-app graphite-app bot temporarily deployed to Playground E2E Test July 30, 2024 05:36 Inactive
@graphite-app graphite-app bot temporarily deployed to Playground E2E Test July 30, 2024 05:36 Inactive
@graphite-app graphite-app bot temporarily deployed to Playground E2E Test July 30, 2024 05:36 Inactive
@Saul-Mirone Saul-Mirone mentioned this pull request Jul 30, 2024
Merged
Saul-Mirone added a commit to toeverything/AFFiNE that referenced this pull request Jul 31, 2024
@Saul-Mirone
chore: bump blocksuite 240730 (#7662)
c7217ed 
## Features
- toeverything/blocksuite#7761 @fourdim
- toeverything/blocksuite#7755 @Saul-Mirone
- toeverything/blocksuite#7598 @Flrande

## Bugfix
- toeverything/blocksuite#7769 @zzj3720
- toeverything/blocksuite#7766 @Saul-Mirone
- toeverything/blocksuite#7767 @akumatus
- toeverything/blocksuite#7726 @siyou
- toeverything/blocksuite#7765 @Saul-Mirone
- toeverything/blocksuite#7763 @fourdim
- toeverything/blocksuite#7764 @fourdim
- toeverything/blocksuite#7760 @fourdim
- toeverything/blocksuite#7742 @fundon
- toeverything/blocksuite#7754 @fundon
- toeverything/blocksuite#7756 @donteatfriedrice
- toeverything/blocksuite#7752 @zzj3720

## Refactor
- toeverything/blocksuite#7758 @doodlewind
- toeverything/blocksuite#7750 @doodlewind
- toeverything/blocksuite#7746 @fundon

## Misc
- toeverything/blocksuite#7744 @Saul-Mirone
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flrande Flrande Flrande approved these changes

Assignees
No one assigned
Labels
merge
Projects
BlockSuite Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fourdim @Flrande