Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add strategy option for portal #8470

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

Saul-Mirone
Copy link
Collaborator

No description provided.

Copy link

vercel bot commented Sep 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2024 4:40am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Sep 26, 2024 4:40am

Copy link

changeset-bot bot commented Sep 26, 2024

⚠️ No Changeset found

Latest commit: 1c869e4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

graphite-app bot commented Sep 26, 2024

Your org has enabled the Graphite merge queue for merging into master

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Saul-Mirone and the rest of your teammates on Graphite Graphite

@Saul-Mirone Saul-Mirone marked this pull request as ready for review September 26, 2024 03:35
@Saul-Mirone Saul-Mirone requested a review from a team as a code owner September 26, 2024 03:35
Copy link

nx-cloud bot commented Sep 26, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 1c869e4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link
Contributor

github-actions bot commented Sep 26, 2024

size-limit report 📦

Path Size
@blocksuite/affine 13 B (0%)
@blocksuite/affine/effects 2.03 MB (+0.02% 🔺)
@blocksuite/affine/block-std 153.14 KB (0%)
@blocksuite/affine/block-std/gfx 75.83 KB (0%)
@blocksuite/affine/global 13 B (0%)
@blocksuite/affine/global/utils 13.82 KB (0%)
@blocksuite/affine/global/env 231 B (0%)
@blocksuite/affine/global/exceptions 552 B (0%)
@blocksuite/affine/global/di 1.65 KB (0%)
@blocksuite/affine/global/types 13 B (0%)
@blocksuite/affine/store 77.06 KB (0%)
@blocksuite/affine/inline 30.45 KB (0%)
@blocksuite/affine/inline/consts 51 B (0%)
@blocksuite/affine/inline/types 13 B (0%)
@blocksuite/affine/presets 1.84 MB (-0.01% 🔽)
@blocksuite/affine/blocks 1.92 MB (+0.01% 🔺)
@blocksuite/affine/blocks/schemas 85.39 KB (0%)

Copy link
Member

@doodlewind doodlewind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

positionStrategy sounds even better

@doodlewind doodlewind changed the title fix: add stragety option for portal fix: add strategy option for portal Sep 26, 2024
@Saul-Mirone
Copy link
Collaborator Author

positionStrategy sounds even better

Renamed

@Saul-Mirone Saul-Mirone force-pushed the 09-26-fix_add_stragety_option_for_portal branch from 2e6870b to 1c869e4 Compare September 26, 2024 04:39
@Saul-Mirone Saul-Mirone merged commit 9f19e4e into master Sep 26, 2024
36 checks passed
@Saul-Mirone Saul-Mirone deleted the 09-26-fix_add_stragety_option_for_portal branch September 26, 2024 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants