Fix path validation for abstract unix socket. #1605
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The validation of abstract unix socket is wrong, and I fixed it.
Look at the original validation code:
Abstract paths don't need a null terminator, so it's valid when it's no longer than the
libc::sockaddr_un.sun_path
. However, when the length of an abstract path equals tosun_path
,(Some(&0), Ordering::Equal)
will match on the second arm and will return an error.I added the branch
(Some(&0), _) => {}
to accept such case.