Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Apple visionOS support to v0.8 #1784

Closed

Conversation

simlay
Copy link

@simlay simlay commented May 7, 2024

This is a backport of #1773 into the v0.8.x branch to enable tokio with the net feature flag to build visionos with a [patches.crates-io].

I cherry-picked the commit from #1773 which brought in extra ci/make targets. There are unresolved issues in #1773 and there's still libc issues on rust-nightly rust-lang/rust#124560. I'll watch the other PRs and update this one accordingly.

@Thomasdezeeuw
Copy link
Collaborator

Let's first get #1773 in.

@Thomasdezeeuw Thomasdezeeuw changed the title Add Apple visionOS support Add Apple visionOS support to v0.8 Jun 9, 2024
@simlay
Copy link
Author

simlay commented Jul 1, 2024

@Thomasdezeeuw shall I pull in the changes from #1795 on this branch? The changes look similar/identical.

@Thomasdezeeuw
Copy link
Collaborator

@simlay is the main goal here adding support for Tokio? Because if so I rather merge tokio-rs/tokio#6635 and not add support to Mio v0.8.

@simlay
Copy link
Author

simlay commented Jul 2, 2024

@simlay is the main goal here adding support for Tokio? Because if so I rather merge tokio-rs/tokio#6635 and not add support to Mio v0.8.

Ah yes. You are correct. I had not seen the mio v1 PR to Tokio. Thanks!

@simlay simlay closed this Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants