Add method BoundedBuf::put_slice
#198
Conversation
A safe way to copy data into a buffer, possibly advancing the initialized length watermark. This generic method is especially useful for FixedBuf, which lacks other population methods available for foreign types.
There was a problem hiding this comment.
Super.
Could you see the use cases for providing two other methods, one for zeroing to the init point and one for zeroing to the capacity and setting the init point to the capacity?
Seems code like
ary.iter_mut().for_each(|m| *m = 0)is expected to be optimized to a memset call, per https://users.rust-lang.org/t/fastest-way-to-zero-an-array/39222
but that's from a few years ago.
One typo, and maybe wait for Noah's second commit today and this is good to go.
src/buf/bounded.rs
Outdated
| @@ -152,6 +153,29 @@ pub trait BoundedBufMut: BoundedBuf<Buf = Self::BufMut> { | |||
| /// The caller must ensure that all bytes starting at `stable_mut_ptr()` up | |||
| /// to `pos` are initialized and owned by the buffer. | |||
| unsafe fn set_init(&mut self, pos: usize); | |||
|
|
|||
| /// Copies the given byte slice slice into the buffer, starting at | |||
|
Following the discussion further, I see there is a slice fill method since 1.50. And even if there weren't, no additional method is needed I just realized. The init slice can be zero filled by the app. There really is no need to fill to capacity. |
|
Once the typo is fixed I'm in favor of merging unless @FrankReh has anything more to add. |
Provide a generic, safe way to copy data into a buffer, possibly advancing the initialized length watermark.
This method is especially useful for
FixedBuf, which lacks other population methods available for the foreign types.This resolves a discussion started in #190 (comment)