Remove ReadyService
#68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The value added by having a separate trait is not obvious. Equivalent behavior can be provided by a `Service` implementation that is always "ready".
|
And, so, generally, we expect service implementations to be graceful when poll_ready has not been called (i.e. should not panic, at least). Should this be reflected in the trait docs? |
olix0r
approved these changes
Apr 25, 2018
olix0r
reviewed
Apr 25, 2018
tower-service/src/lib.rs
Outdated
| @@ -189,6 +189,9 @@ pub trait Service { | |||
| /// implementations should take care to not call `poll_ready`. If the | |||
| /// service is at capacity and the request is unable to be handled, the | |||
| /// returned `Future` should resolve to an error. | |||
| /// | |||
| /// Calling `poll_ready` before calling `call` is permitted. The | |||
There was a problem hiding this comment.
Calling call before calling poll_ready is permitted!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value added by having a separate trait is not obvious. Equivalent
behavior can be provided by a
Serviceimplementation that is always"ready".