Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: relax MSRV to 1.63 #792

Closed
wants to merge 1 commit into from
Closed

Conversation

tottoto
Copy link
Contributor

@tottoto tottoto commented Aug 24, 2024

Resolves #785. Relaxes MSRV to 1.63 from 1.64.

@paolobarbolini
Copy link
Contributor

Considering that the published crate gets the Cargo.toml flattened I wander if the MSRV is already 1.63 without this PR 🤔. See https://docs.rs/crate/tower/0.5.1/source/Cargo.toml

@jplatte
Copy link
Contributor

jplatte commented Sep 20, 2024

This effectively reverts #778. Is there a reason you chose to do that instead of fixing #785 the "obvious" way, by updating the changelog?

@tottoto
Copy link
Contributor Author

tottoto commented Sep 20, 2024

I'm not sure what is the obvious way, but the reason is hyper-util's MSRV is 1.63 and tower doesn't use any 1.64 features other than workspace inheritance. As I think maintaining support for older versions of Rust incurs a certain cost, if this does not conform to tower's policy, I will withdraw this proposal.

@jplatte
Copy link
Contributor

jplatte commented Sep 20, 2024

I don't have a strong opinion on this one way or the other, let's see what Sean says in hyperium/hyper-util#144.

@paolobarbolini
Copy link
Contributor

Isn't the MSRV effectively 1.63 once the crate is published? I'd expect a cargo version not aware of workspace dependencies to still be able to parse this https://docs.rs/crate/tower/0.5.1/source/Cargo.toml

@jplatte
Copy link
Contributor

jplatte commented Sep 20, 2024

That's a good point...

@seanmonstar
Copy link
Collaborator

At least for hyper-util, this isn't needed, since I removed the dependency on tower.

@tottoto
Copy link
Contributor Author

tottoto commented Sep 27, 2024

Closed as the main motivation has been resolved.

@tottoto tottoto closed this Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changelog says that MSRV is 1.63 but it's 1.64
4 participants