Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSBI support #80

Merged
merged 20 commits into from
Oct 2, 2020
Merged

JSBI support #80

merged 20 commits into from
Oct 2, 2020

Conversation

bencmbrook
Copy link
Member

@bencmbrook bencmbrook commented Sep 25, 2020

Adds JSBI to support browsers without BigInt. This is a dynamic polyfill which allows usage of native BigInts where it's possible — but not in syntax. In syntax, we're committing to the function interface of JSBI rather than native expressions like a + b and 123n.

Thanks to @vincaslt for the conversion in read.js and write.js.

@bencmbrook bencmbrook changed the title Bencmbrook/jsbi JSBI support Sep 25, 2020
@vincaslt
Copy link
Contributor

Good idea

Copy link
Member

@eligrey eligrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! From my understanding, this should be close to native perf with the use of those native expressions.

I haven't tested this locally

@bencmbrook bencmbrook merged commit 2bd05e5 into master Oct 2, 2020
@delete-merged-branch delete-merged-branch bot deleted the bencmbrook/jsbi branch October 2, 2020 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants