Remove warning for using static_dist_dir with urls #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lighthouse-ci does support using explicit URLs with '--static-dist-dir'. Support was added for this in late 2019.
|
Thank you @gregjopa for your kind words and such a well-documented PR ❤️ |
|
Thanks @alekseykulikov 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the warning around using urls with a static dist directory. Support for this was added to lighthouse-ci in November 2019: GoogleChrome/lighthouse-ci@93b6742.
I set this up for my personal blog which uses Gatsby.js and ran into this warning even though everything's working fine:
It seems like this warning is unnecessary now.
Also thanks for this awesome project @alekseykulikov and Google Team 💯 It's amazing that this is all free to use.