NAS-107309 / 12.1 / Add ZSTD and ZSTD-FAST to WebUI #4559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
william-gr
reviewed
Aug 20, 2020
src/app/pages/storage/volumes/zvol/zvol-form/zvol-form.component.ts
Outdated
Show resolved
Hide resolved
Openzfs2.0 adds ZSTD and ZSTD-fast compression. See: openzfs/zfs/pull/10278 This commit adds the following compression values to be accepted by the pool middleware: - ZSTD - ZSTD-5 - ZSTD-7 - ZSTD-FAST These levels give an acceptable and balanced spread of both compression ratio and performance. (see graphs in openzfs/zfs/pull/10278 ) Notes: - Requires an update to OpenZFS before being able to be used - Might also want to backport to 12U1 or even 12RC1 - Related middleware changes are also required, see: truenas/middleware/pull/5517 Signed-off-by: Kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl>
PrivatePuffin
force-pushed
the
add-zstd
branch
from
7bfa0a1
to
018d262
Compare
PrivatePuffin
force-pushed
the
add-zstd
branch
from
5a14a5a
to
606c75a
Compare
william-gr
approved these changes
Aug 21, 2020
|
note: this should not be merged into master and 12.0 until the related openzfs is mergd in |
|
@Erinix It does, I put that scentence in the description in bold on both PR's to prevent any mistakes! |
|
@freqlabs You might want to update ZoF (Guess you have write access) and the pkg... |
|
@Ornias1993 Ports PRs |
erincodepirate
approved these changes
Aug 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Openzfs2.0 adds ZSTD and ZSTD-fast compression.
See: openzfs/zfs/pull/10278
This commit adds the following compression values to be accepted by the pool middleware:
These levels give an acceptable and balanced spread of both compression ratio and performance.
(see graphs in openzfs/zfs/pull/10278 )
Notes:
Signed-off-by: Kjeld Schouten-Lebbing kjeld@schouten-lebbing.nl