Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: A fix for CSS Variables and some proposal #35563

Merged
merged 5 commits into from
Dec 18, 2021

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Dec 17, 2021

Remove dupe section in Docs > Content > Reboot
Dropdowns wording proposal
Some URLs refactoring

  • I don't know if the correct wording for radio buttons in Forms > Checks & Radios is 'selected' or 'checked' (I could modify that in the same PR?)

@louismaximepiton louismaximepiton changed the title docs: Fix CSS variables sections docs: A fix for CSS Variables and some proposal Dec 17, 2021
@@ -12,7 +12,7 @@
<header class="bd-header bg-dark py-3 d-flex align-items-stretch border-bottom border-dark">
<div class="container-fluid d-flex align-items-center">
<h1 class="d-flex align-items-center fs-4 text-white mb-0">
<img src="/docs/5.1/assets/brand/bootstrap-logo-white.svg" width="38" height="30" class="me-3" alt="Bootstrap">
<img src="/docs/{{< param docs_version >}}/assets/brand/bootstrap-logo-white.svg" width="38" height="30" class="me-3" alt="Bootstrap">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these, good catch ❤

Copy link
Member

@ffoodd ffoodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overall feels right indeed. Thanks!

@ffoodd
Copy link
Member

ffoodd commented Dec 17, 2021

Regarding checked, it's the good wording since it's the dedicated attribute's name.

@XhmikosR XhmikosR merged commit 4216254 into twbs:main Dec 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants