Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use box-shadow CSS vars instead of Sass vars in assets and variables #38976

Merged
merged 1 commit into from
Aug 5, 2023

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Jul 27, 2023

Description

This PR uses --bs-box-shadow* CSS vars instead of $box-shadow* Sass vars in our scss/_variables.scss and our site/assets/scss/_*scss in the same spirit of what we can do with --bs-border-width for instance.

In order to test it for some use cases, don't forget to enable locally $enable-shadows to see the shadows, or to keep it disabled to check for non-regressions.

There shouldn't be anything to mention in the migration guide or that can be breaking for folks. It should be safe to be embedded even in a dot version.

Motivation & Context

Following up #38816 and the following comment #38816 (review).

Type of changes

  • Refactoring (non-breaking change)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • (N/A) My change introduces changes to the documentation
  • (N/A) I have updated the documentation accordingly
  • (N/A) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

@julien-deramond julien-deramond marked this pull request as ready for review July 27, 2023 21:08
@julien-deramond julien-deramond requested a review from a team as a code owner July 27, 2023 21:08
Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels safer than border-width since we don't modify the CSS vars. LGTM!

@mdo mdo merged commit 78b4e5d into main Aug 5, 2023
13 checks passed
@mdo mdo deleted the main-jd-replace-sass-box-shadow-with-css-var branch August 5, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants