This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
Cleanup the Storm API a bit #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mixing WS with code changes... |
| def service[K, V](serv: => ReadableStore[K, V]): StormService[K, V] = StoreWrapper(() => serv) | ||
|
|
||
| def toStormSource[T](spout: Spout[T], | ||
| defaultSourcePar: Option[Int] = None)(implicit timeOf: TimeExtractor[T]): StormSource[T] = |
There was a problem hiding this comment.
Indentations appear odd, increasing indentation because of split in args? args should be further indented but method code the normal amount imo
There was a problem hiding this comment.
tell me what you want to type.
There was a problem hiding this comment.
def toStormSource[T](spout: Spout[T],
defaultSourcePar: Option[Int] = None)(implicit timeOf: TimeExtractor[T]): StormSource[T] =
SpoutSource(spout.map(t => (timeOf(t), t)), defaultSourcePar.map(option.SpoutParallelism(_)))
|
yes, whitespace changes here, but in only two cases. I added type annotations to the returns. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.