This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
Refactors the bolts from storm to be independent workers in online. With... #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith just a base bolt in storm to do the functions there
|
|
||
| } | ||
|
|
||
| object InflightTuples { |
There was a problem hiding this comment.
Seems like a metrics concept.
| // If we incremented on something that was 0 or negative | ||
| // And not in a failed state, then this is an error | ||
| if((newS.counter - by <= 0) && !newS.failed) { | ||
| throw new Exception("Invalid call on an inputstate, we had already decremented to 0 and not failed.") |
There was a problem hiding this comment.
I think this should be in incrBy. It should not allow a faulty transition (or at least, it should be a method on the state, so we don't change states in a fault.
| } | ||
| } | ||
|
|
||
| def fail(fn: (T => Unit)) { |
There was a problem hiding this comment.
similar: def fail(fn: T => U): U = {
|
@johnynek should be all updated per comments |
| val futWithFail = tick.onFailure { thr => | ||
| responses.put(((List(), Failure(thr)))) | ||
| } | ||
| val fut = handleSuccess(futWithFail) |
There was a problem hiding this comment.
line 46 - 52 is duplicated on 58 - 63. Can we make one function and call that in both places?
johnynek
added a commit
that referenced
this pull request
Dec 5, 2013
Refactors the bolts from storm to be independent workers in online. With...
snoble
pushed a commit
to snoble/summingbird
that referenced
this pull request
Sep 8, 2017
twitterGH-388: Fix CMS test issue caused by roundtripping depth->delta->depth
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... just a base bolt in storm to do the functions there