This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
Feature/add pruning support #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| object Store extends java.io.Serializable { | ||
| // This could be moved to scalding, but the API needs more design work | ||
| // This DOES NOT trigger a grouping | ||
| def mapsideReduce[K,V](pipe: TypedPipe[(K, V)])(implicit sg: Semigroup[V]): TypedPipe[(K, V)] = { |
There was a problem hiding this comment.
This was added to scalding:
We should remove this when release 0.9.0
…eature/add_pruning_support
…eature/add_pruning_support
…/add_pruning_support
|
Updated this with a merge of latest develop to clean up the diff |
|
lgtm. Will merge when green. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separates out the add pruning, based ontop of the previous refactor. Adds in the proxy batched store also and a test of the pruning. (The much simpler one of the frozen + filter)