This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
MergeableStoreFactory extends java.io.Serializable #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sorry we missed this. Generally all our traits need this. :/ Merge when green. |
|
Had to exclude two targets from summingbird-example to get this to pass, but the build is green now |
|
I guess we can merge this. It may hit someone externally later if they don't explicitly add this stuff back, perhaps. |
johnynek
added a commit
that referenced
this pull request
Apr 8, 2015
…serializable MergeableStoreFactory extends java.io.Serializable
snoble
pushed a commit
to snoble/summingbird
that referenced
this pull request
Sep 8, 2017
…nce (twitter#616) * Commute set addition operands to avoid potentially quadratic performance * Avoid tuple allocation in SetMonoid.plus
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was breaking serialization internally, adding fix