update CI go version. #1210
update CI go version. #1210
Conversation
There was a problem hiding this comment.
LGTM, but maybe run it by @Groxx , I have less strong opinions here
|
yea, I think we can do this. it'll let us start formatting for 1.19 and then we can get the godoc improvements too. I believe the go.mod value will still prevent us from using generics and stuff that doesn't exist in 1.13 (which is good). we should probably consider bumping that to at least 1.18 so we can use generics at some point. 1.18 is about 9 months old now, and 1.13 is ancient, seems probably safe to update and force that on our users. |
|
will we want to include 1.19-fmt in this commit, or a later one, or did the earlier one take care of that? I forget how all this works with our CI pipeline, but it's worth keeping the inconsistent-fmt gap small. |
What changed?
Updating docker files to use 1.19 go version in CI pipelines
Why?
How did you test it?
CI pipeline passes.
Potential risks