Test-suite bugfix: local activity errors were not encoded correctly #1247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The added test hopefully reveals the issue - prior to this fix, that `err := f.Get(...)` -> `errors.Is(err, ...)` check passed, because the error value was not ever encoded into a `*GenericError`. Thankfully this was only a test environment bug, and a user discovered it due to writing tests.
| @@ -1159,10 +1159,10 @@ func (weh *workflowExecutionEventHandlerImpl) ProcessLocalActivityResult(lar *lo | |||
| if lar.err != nil { | |||
| errReason, errDetails := getErrorDetails(lar.err, weh.GetDataConverter()) | |||
| lamd.ErrReason = errReason | |||
| lamd.ErrJSON = string(errDetails) | |||
| lamd.ErrJSON = string(errDetails) // TODO: this is not json, nor is it necessarily a valid string | |||
There was a problem hiding this comment.
clarification, not validated as being json or even a string? or never json?
There was a problem hiding this comment.
it's user-encoded data in an arbitrary format (because it uses their dataconverter).
json is the default, but since it's arbitrary IMO that means "never json".
davidporter-id-au
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The added test hopefully reveals the issue - prior to this fix,
that
err := f.Get(...)->errors.Is(err, ...)check passed, becausethe error value was not ever encoded into a
*GenericError.Thankfully this was only a test environment bug, and a user discovered
it due to writing tests.
The non-test behavior can be seen split between these two locations:
cadence-client/internal/internal_event_handlers.go
Lines 1159 to 1163 in ad91fc7
cadence-client/internal/internal_event_handlers.go
Lines 1132 to 1135 in ad91fc7
... which also show incorrect / pointless string/byte conversions.
I've left comments there just to prevent confusion, but these fields are
probably worth changing at some point.