Create a new poller thread pool usage metric #1275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ric meant the amount of buffer left in the poller channel. If there are non-remaining, then polling will halt.
shijiesheng
reviewed
Oct 10, 2023
shijiesheng
approved these changes
Oct 10, 2023
timl3136
added a commit
that referenced
this pull request
Nov 4, 2023
Create new poller thread pool usage metrics. ConcurrentTaskQuota is the number of buffer in poller thread channel and ConcurrentTaskRunning is current utilization of that channel. If ConcurrentTaskRunning is exceeding ConcurrentTaskQuota, polling will halt and result in under utilization and backlog as a result.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a new poller thread pool usage metric for the amount of buffer left in the poller channel. If there are non-remaining, then polling will halt.
What changed?
Added a new metric regarding the usage and remaining capacity of the poller channel
Why?
We are aiming to understand current poller utilizations and improve the overall utilization as a result. This metric allows us to determine whether there exists a need to tune the amount of buffer of the channel for high traffic customers.
How did you test it?
Tested on development environment
Potential risks
No risks considering that is only a new metric