Update client wrappers with new async APIs #1327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taylanisikdemir
requested review from
Groxx,
shijiesheng,
agautam478,
jakobht,
3vilhamster,
dkrotx and
demirkayaender
as code owners
Codecov Report
Additional details and impacted files
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Groxx
added a commit
that referenced
this pull request
Apr 1, 2024
Seems like this has been left un-pinned and un-documented for a long time. Might as well fix that, so we can address the new async APIs in e.g. #1327 in a standardized way.
taylanisikdemir
force-pushed
the
taylan/update_clients_with_async_apis
branch
from
5740ef6
to
701e780
Compare
Pull Request Test Coverage Report for Build 018e9ca6-a094-49e0-99cd-bf58edb8502cDetails
💛 - Coveralls |
Groxx
reviewed
Apr 1, 2024
Groxx
reviewed
Apr 1, 2024
Groxx
reviewed
Apr 1, 2024
Groxx
reviewed
Apr 1, 2024
Groxx
reviewed
Apr 1, 2024
Groxx
requested changes
Apr 2, 2024
There was a problem hiding this comment.
gonna request some relatively minor things, as there's some odd inconsistencies / unrelated checks / tests that don't really test anything.
generally: tackle what you want / what you agree with, since a moderate amount of the comments are fuzzy.
overall looks good though, should be an easy re-review. and I'm curious if you have any reasons for/against adding another metrics tag for async APIs.
Groxx
approved these changes
Apr 2, 2024
Groxx
added a commit
that referenced
this pull request
Apr 5, 2024
Followups from #1327: 1. simplifying the memo/search-attr encoding tests 2. making sure the dataconverter tests can detect correct vs incorrect encoder use 1 is pretty simple: memos and search attrs are ALWAYS JSON because the server must interpret them, so the exact bytes should not change in the future. A hardcoded string is easy to verify, and strengthens the guarantee that "this should not change even if other encoding changes". 2 is more interesting: as originally written, the test would still pass if the custom dataconverter was *not* saved and used. The type-assertion to check the internal field somewhat prevents that, but it's unnecessary and a disjointed check. So it has been rewritten: now the serialized request bytes must clearly come from the test encoder, not the default encoder, and they must be detectably different.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Updating client wrappers to expose new async methods.
These changes were missed in #1321.
How did you test it?
Unit test