improve example test by sorting output #1366
Conversation
ketsiambaku
requested review from
Groxx,
shijiesheng,
jakobht,
3vilhamster,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filesContinue to review full report in Codecov by Sentry.
|
| @@ -75,6 +77,9 @@ func (ati *activityTrackerImpl) Stats() Activities { | |||
| }{Info: a, Count: count}) | |||
| } | |||
| } | |||
| sort.Slice(activities, func(i, j int) bool { | |||
| return strings.Compare(strings.ToLower(activities[i].Info.ActivityType), strings.ToLower(activities[j].Info.ActivityType)) < 0 | |||
There was a problem hiding this comment.
Sorting makes perfect sense, but there's no reason to ToLower here afaict. It'll just make things more ambiguous than they are IRL, where strings need to be identical in both workers and example-test output checks.
I saw the last comment after merging. Followed up in #1367 |
What changed?
Improving the example test by sorting the activities returned by Stats()
The example implementation range over a map and return the result in a slice. Because of this, the assertion against expected result would not always pass since the order is random. This made the test flaky
Why?
How did you test it?
unit tests
Potential risks