Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add types to existing common values formatter #680

Conversation

Assem-Hafez
Copy link
Contributor

@Assem-Hafez Assem-Hafez commented Sep 27, 2024

Summary

Add types to existing common event value formatters. Previously we didn't have types generated for history events so typing was hard.

Changes

  • Fix formatter argument and return types
  • updating test cases to include missing values, add correct types of values and ignore typescript issues when it we send wrong type values on purpose to simulate bad input.

@Assem-Uber Assem-Uber merged commit f9c5df6 into uber:release/4.0.0 Sep 27, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants