Made some internal classes public

[bergmania]

Made some internal classes public, so its possible to bypass security for packages like DTGE.
Related: #15572

Fixes: #15560

Example

using Umbraco.Core;
using Umbraco.Core.Cache;
using Umbraco.Core.Configuration;
using Umbraco.Core.Logging;
using Umbraco.Core.Persistence;
using Umbraco.Core.PropertyEditors;
using Umbraco.Core.Scoping;
using Umbraco.Core.Services;
using Umbraco.Web;
using Umbraco.Web.Editors;
using Umbraco.Web.Models.ContentEditing;
using Umbraco.Web.WebApi.Filters;
using Umbraco.Web.Editors.Filters;
using Umbraco.Web.Editors.Binders;
using System.Web.Http.ModelBinding;

namespace ClassLibrary2
{

    [Umbraco.Web.Mvc.PluginController("dtge")]
    [UmbracoApplicationAuthorize(Constants.Applications.Content)]
    public class WhateverController : BackOfficeNotificationsController
    {
        private ContentController _contentController;

        public WhateverController(PropertyEditorCollection propertyEditors, IGlobalSettings globalSettings,
     IUmbracoContextAccessor umbracoContextAccessor, ISqlContext sqlContext, ServiceContext services,
     AppCaches appCaches, IProfilingLogger logger, IRuntimeState runtimeState, UmbracoHelper umbracoHelper,
     IScopeProvider scopeProvider)
     : base(globalSettings, umbracoContextAccessor, sqlContext, services, appCaches, logger, runtimeState, umbracoHelper)
        {
            _contentController = new ContentController(propertyEditors, globalSettings, umbracoContextAccessor, sqlContext, services, appCaches,logger,runtimeState,umbracoHelper,scopeProvider);
        }


        [FileUploadCleanupFilter]
        [ContentSaveValidation(skipUserAccessValidation: true)]
        public ContentItemDisplay PostSaveBlueprint([ModelBinder(typeof(BlueprintItemBinder))] ContentItemSave contentItem)
        {
            return _contentController.PostSaveBlueprint(contentItem);
        }
    }
}

[Matthew-Wise]

Hi,
Is there a planned release date for this a currently have 2 live sites with this issue one of which is chasing for a fix date as they dont want to give all editors settings access.

Thanks
Matt

[bergmania]

Plan is next week.. I'll create it on our now

[nikolajlauridsen]

LGTM 👍

[ws-graham]

Hi, Is there a planned release date for this a currently have 2 live sites with this issue one of which is chasing for a fix date as they dont want to give all editors settings access.

Thanks Matt

Does this fix resolve the issue with editors or does this open up the ability for the DTGE to be modified to fix the issue? As on #15572 I understood modifications needed to be made with the DTGE package as well?

[lukehook]

Hi, Is there a planned release date for this a currently have 2 live sites with this issue one of which is chasing for a fix date as they dont want to give all editors settings access.
Thanks Matt

Does this fix resolve the issue with editors or does this open up the ability for the DTGE to be modified to fix the issue? As on #15572 I understood modifications needed to be made with the DTGE package as well?

As far as I understand it, yes this simply opens it up so that the DTGE package can be amended to circumvent the issues. I'm unsure of the status of anybody picking that up DTGE end