Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emoji autocomplete #378

Closed
umputun opened this issue Jul 21, 2019 · 3 comments
Closed

Emoji autocomplete #378

umputun opened this issue Jul 21, 2019 · 3 comments
Labels
frontend good-first-issue help wanted
Milestone
v1.5

Comments

@umputun
Copy link
Owner

umputun commented Jul 21, 2019

With #374 users can enter emoji as :blah: however we don't help them on UI side. I can expose emoji_enabled flag to /config response and it will be nice to support such auto-completion/selection on UI side
umputun added a commit that referenced this issue Jul 21, 2019
@umputun
expose emoji_enabled flag in /config response #378
ad3b7c6
@StaroKep
Copy link
Contributor

StaroKep commented Oct 2, 2019

@umputun, привет. Думаю заняться этой задачей.

Это нормально, что на локальной машине не отображаются emoji в комментариях?
https://yadi.sk/i/Ju5zcAjYdb8rNw

Нормально, если при вводе emoji будет появляться выпадающее меню, в котором стрелками можно выбрать необходимый emoji?

@umputun
Copy link
Owner Author

umputun commented Oct 2, 2019

@StaroKep спасибо, что вызвался. Пожалуйста, используй english во всех коммуникациях тут, т.к. не все из участников знают великий-и-могучий.

emoji should be working locally the same way as on demo site. I have tried the master and had no problem with emoji processing/preview. Make sure you update your local repo and build it.

kiwer-201910-02155511-u662a

regarding ui - yeah, it should open a selection and user should be able to navigate with mouse or keyboard. This is how rocket.chat does it:

bmc78-201910-02155815-qjkaq

@StaroKep
Copy link
Contributor

StaroKep commented Oct 3, 2019

@umputun ok. Thanks for the information!
Configured the local version for frontend development.
I’ll make a branch and I will implement it in my free time.

@StaroKep StaroKep mentioned this issue Oct 4, 2019
Closed
Mavrin added a commit to Mavrin/remark that referenced this issue Jan 11, 2020
@Mavrin
umputun#378 [POC] emoji suggestion
68d397d
Mavrin added a commit to Mavrin/remark that referenced this issue Jan 11, 2020
@Mavrin
umputun#378 [POC] use lazy load for nodeEmoji
a1595f0
Mavrin added a commit to Mavrin/remark that referenced this issue Jan 11, 2020
@Mavrin
umputun#378 [POC] apply remark styles only for light theme
aeb064b
Mavrin added a commit to Mavrin/remark that referenced this issue Jan 11, 2020
@Mavrin
umputun#378 [POC] fix some styles
4bfa65f
Mavrin added a commit to Mavrin/remark that referenced this issue Jan 12, 2020
@Mavrin
umputun#378 add emoji suggestion
e15d4fe
Mavrin added a commit to Mavrin/remark that referenced this issue Jan 12, 2020
@Mavrin
umputun#378 use lazy load for nodeEmoji
ad88b34
Mavrin added a commit to Mavrin/remark that referenced this issue Jan 12, 2020
@Mavrin
umputun#378 apply remark styles only for light theme
52ac9c7
Mavrin added a commit to Mavrin/remark that referenced this issue Jan 12, 2020
@Mavrin
umputun#378 add dark theme
8cedf72
Mavrin added a commit to Mavrin/remark that referenced this issue Jan 12, 2020
@Mavrin
umputun#378 fix test
716fbe2
Mavrin added a commit to Mavrin/remark that referenced this issue Jan 12, 2020
@Mavrin
umputun#378 use permanent class names
ecb6c4c
Mavrin added a commit to Mavrin/remark that referenced this issue Jan 12, 2020
@Mavrin
umputun#378 add emoji suggestion
783f403
Mavrin added a commit to Mavrin/remark that referenced this issue Jan 12, 2020
@Mavrin
umputun#378 use lazy load for nodeEmoji
5314c9a
Mavrin added a commit to Mavrin/remark that referenced this issue Jan 12, 2020
@Mavrin
umputun#378 apply remark styles only for light theme
d6c96dc
Mavrin added a commit to Mavrin/remark that referenced this issue Jan 12, 2020
@Mavrin
umputun#378 add dark theme
81bd954
Mavrin added a commit to Mavrin/remark that referenced this issue Jan 12, 2020
@Mavrin
umputun#378 fix test
595f438
Mavrin added a commit to Mavrin/remark that referenced this issue Jan 12, 2020
@Mavrin
umputun#378 use permanent class names
3b38889
Mavrin added a commit to Mavrin/remark that referenced this issue Jan 13, 2020
@Mavrin
umputun#378 flip if else for readability
2369923
umputun pushed a commit that referenced this issue Jan 14, 2020
@Mavrin @umputun
#378 Emoji suggestions (#546)
17be003 
* #378 add emoji suggestion

* #378 use lazy load for nodeEmoji

* #378 apply remark styles only for light theme

* #378 add dark theme

* #378 fix test

* #378 use permanent class names

*  #378 flip if else for readability
@umputun umputun added this to the v1.5 milestone Jan 21, 2020
@umputun umputun closed this as completed Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
frontend good-first-issue help wanted
Projects
None yet
Milestone
v1.5
Development

No branches or pull requests
2 participants
@umputun @StaroKep