Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to lcw v2 with generic types #1742

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Update to lcw v2 with generic types #1742

merged 1 commit into from
Feb 20, 2024

Conversation

paskal
Copy link
Sponsor Collaborator

@paskal paskal commented Feb 20, 2024

Now the types cast would be explicit thanks to generics.

@paskal paskal requested a review from umputun as a code owner February 20, 2024 19:32
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7978981653

Details

  • -7 of 23 (69.57%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.008%) to 84.886%
Changes Missing Coverage Covered Lines Changed/Added Lines %
backend/app/store/service/title.go 6 9 66.67%
backend/app/cmd/server.go 7 11 63.64%
Totals Coverage Status
Change from base Build 7978195415: 0.008%
Covered Lines: 5976
Relevant Lines: 7040
💛 - Coveralls

umputun
umputun reviewed Feb 20, 2024
View reviewed changes
Copy link
Owner

@umputun umputun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple of minor things

backend/app/cmd/server.go Show resolved Hide resolved
backend/app/rest/api/admin_test.go Show resolved Hide resolved
@umputun umputun merged commit 1313dee into master Feb 20, 2024
4 checks passed
@umputun umputun deleted the paskal/lcw_v2 branch February 20, 2024 20:15
@paskal paskal added this to the v1.13.0 milestone Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umputun umputun umputun left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@paskal @coveralls @umputun