Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "contradiction index" metric #278

Merged
merged 1 commit into from
Feb 17, 2019

Conversation

AnyRoad
Copy link
Contributor

@AnyRoad AnyRoad commented Feb 17, 2019

Issue #274

  • show the value of controversy in the hover on scores: value if it exists,
    "No controversy." if value is zero, "No votes yet." if there are no votes.
  • add a new sorting mode "controversial" to "sort by" dropdown

image

image

image

@umputun
Copy link
Owner

umputun commented Feb 17, 2019

Not sure I understand what is "No controversy" and "No votes yet." and why we show it. If the value is 0 (or none) it should be just "Controversy: 0.00", why even make a special case for this?

@AnyRoad
Copy link
Contributor Author

AnyRoad commented Feb 17, 2019

Initially I thought it would be better to show some explanation why there is no controversy (no votes or all votes up/down), but now I agree that the reason is too straightforward to make special case. I will change to just display zero.

* show the value of `controversy` in the hover on scores
* add a new sorting mode "controversial" to "sort by" dropdown
@AnyRoad AnyRoad force-pushed the add_contradiction_index_metric branch from 9b19a9f to a26684c Compare February 17, 2019 22:39
@umputun umputun merged commit d628256 into umputun:master Feb 17, 2019
@AnyRoad AnyRoad deleted the add_contradiction_index_metric branch February 18, 2019 22:06
@paskal paskal added this to the v1.3 milestone Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants