Simpler image service #580

umputun · 2020-01-25T08:31:45Z

I have investigated the ability to add remote image store Remote (rpc) implementation of image.store #572 and found the image.Store interface a little bit confusing. I have tried to make the intent as clear as possible and demoted internally used commit and cleanup to private methods.
replaced immediate commit (in rest/proxy) to delayed one via Submit.
fixed potential race inside Close
added some comment
minor refactoring

@smaant - pls take a look. Hopefully, it makes sense to you.

umputun added 4 commits January 25, 2020 02:14

fix potential race on close

22fb318

move validate inside

cea92e1

demote commit and cleanup in image.Store to non-exposed functions.

de35c78

replace immediate image commit with delayed via Submit

266791b

umputun requested a review from smaant January 25, 2020 08:31

paskal previously approved these changes Jan 25, 2020

View reviewed changes

minor: remove error logging, rename tests

07af608

umputun dismissed paskal’s stale review via 07af608 January 25, 2020 18:17

umputun and others added 2 commits January 25, 2020 12:33

minor: err wrapping, comments wording

8a42c10

clarify FileSystem.Save code

afe8ed6

paskal mentioned this pull request Jan 25, 2020

Preserving external images (issue #399) #447

Merged

paskal previously approved these changes Jan 25, 2020

View reviewed changes

attempt to fix #584 by making submitted image commits on a half of TTL

e4e80b9

umputun dismissed paskal’s stale review via e4e80b9 January 27, 2020 19:17

umputun merged commit 019fa9e into master Jan 27, 2020

umputun deleted the simpler-image branch January 27, 2020 20:18

umputun added the backend label Apr 12, 2020

umputun added this to the v1.6 milestone Apr 12, 2020

Provide feedback