Add localization #602
Merged
Add localization #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paskal
reviewed
Feb 17, 2020
alexeyten
reviewed
Feb 17, 2020
Mavrin
force-pushed
the
localization
branch
3 times, most recently
from
0b153d2
to
b8e2520
Compare
Mavrin
force-pushed
the
localization
branch
2 times, most recently
from
c510ab5
to
c828714
Compare
akellbl4
reviewed
Feb 22, 2020
frontend/app/components/auth-panel/__anonymous-login-form/auth-panel__anonymous-login-form.tsx
Show resolved
Hide resolved
paskal
previously approved these changes
Feb 22, 2020
Closed
paskal
requested changes
Feb 22, 2020
paskal
previously approved these changes
Feb 23, 2020
akellbl4
requested changes
Feb 23, 2020
paskal
previously approved these changes
Feb 24, 2020
codiflow
suggested changes
Feb 24, 2020
There was a problem hiding this comment.
The name of the variable in line 60 (frontend/app/locales/de.json) should be reply instead of replay.
So this would need a change in the following files too:
frontend/app/components/comment-form/comment-form.tsx, Line 389 (Also changeReplaytoReply)frontend/app/locales/en.jsonfrontend/app/locales/ru.json
The German translation is already done - I would commit it once the pull request got merged.
akellbl4
reviewed
Mar 3, 2020
akellbl4
reviewed
Mar 3, 2020
akellbl4
previously approved these changes
Mar 3, 2020
Co-Authored-By: Pavel Mineev <pavel@mineev.me>
akellbl4
approved these changes
Mar 4, 2020
|
So am I right that merging seems to be possible very soon? :-) Can't wait to contribute my German translation. |
umputun
approved these changes
Mar 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces localization infrastructure. I localized all components.
Also I added some translation for ru lang.