Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Application shutdown problem fix #658

Merged
merged 3 commits into from
Apr 12, 2020
Merged

Application shutdown problem fix #658

merged 3 commits into from
Apr 12, 2020

Conversation

paskal
Copy link
Sponsor Collaborator

@paskal paskal commented Apr 11, 2020

  • fix a few things in Readme
  • shutdown all services before stopping the application (previously shutting down services was a non-blocking operation and likely did not complete properly)
  • fix image.Service.Close() as previously it was stuck for eternity in case image.Service.Submit was not called at least once during the application run

This PR likely will improve the situation with the problem described in #584 as previously image.Service.Close() likely was not even called on program shutdown.

@paskal paskal requested a review from umputun April 11, 2020 15:52
@paskal paskal mentioned this pull request Apr 11, 2020
Merged
@umputun umputun merged commit a133ab3 into master Apr 12, 2020
@umputun umputun deleted the termination_fix branch April 12, 2020 08:34
@umputun umputun added this to the v1.6 milestone Apr 12, 2020
@paskal paskal mentioned this pull request Apr 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umputun umputun umputun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.
2 participants
@paskal @umputun