Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: configure nitro alias #175

Merged
merged 6 commits into from
Mar 27, 2024
Merged

chore: configure nitro alias #175

merged 6 commits into from
Mar 27, 2024

Conversation

danielroe
Copy link
Contributor

What does this PR do?

A quick PR to show how to configure a type-only alias. I think Nitro should likely do this itself (I regard it as a bug) so hopefully this is temporary only...

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

Required

  • Read Contributing Guide
  • Self-reviewed my own code
  • Tested my code in a local environment
  • Commented on my code in hard-to-understand areas
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the UnInbox Docs if changes were necessary

@McPizza0
Copy link
Member

@BlankParticle this PR adds importing from project root via ~ in all nitro server
but the checks are failing
seems like tsc needs tsc-alias to resolve path aliases
thoughts?

@BlankParticle
Copy link
Member

So the problem is we import stuff in between the apps we have, now every app depends on some auto generated types that the app itself is aware of, but other apps importing from that app is not aware. I have made is do that the apps now load generated tsconfig from other apps.

It is a hacky workaround, but we have to deal with it or make the stuff that is shared between apps into their seperate packages.

@McPizza0 McPizza0 merged commit 7d50fe4 into un:main Mar 27, 2024
2 checks passed
McPizza0 added a commit that referenced this pull request Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants