Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix rust bindings build on windows #1584

Merged
merged 11 commits into from
Apr 16, 2022
Merged

fix rust bindings build on windows #1584

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
ddfd59d
unify rust build.rs for win/nix and fix it on windows
shuffle2 Apr 8, 2022
416c256
msvc: quiet some warnings
shuffle2 Apr 14, 2022
4bc949c
update gh workflow for rust
shuffle2 Apr 15, 2022
79f9d37
sigp_set_architecture DNE so dont reference it
shuffle2 Apr 15, 2022
cd703f7
cmake: set C standard to C11
shuffle2 Apr 15, 2022
a6edb22
rust msvc: hack around symbol name collisions
shuffle2 Apr 15, 2022
e8e5f77
rust: set some args from build.rs instead of hardcoding
shuffle2 Apr 15, 2022
0f6dc90
rust allow-multiple-definition for non-msvc
shuffle2 Apr 15, 2022
e4a25ce
cmake: expect msvcrt setting in CMAKE_C_FLAGS
shuffle2 Apr 15, 2022
18963eb
yet another try to make CI happy
shuffle2 Apr 15, 2022
1604239
workaround cc misdetection on mac
shuffle2 Apr 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions bindings/rust/build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,9 @@ fn build_with_cmake() {
let compiler = cc::Build::new().get_compiler();
let has_ninja = if compiler.is_like_msvc() {
setup_env_msvc(&compiler);
// this is a BIG HACK that should be fixed in unicorn's cmake!!
shuffle2 marked this conversation as resolved.
Show resolved Hide resolved
// but for now, tell link.exe to ignore multiply defined symbol names
println!("cargo:rustc-link-arg=/FORCE:MULTIPLE");
true
} else {
ninja_available()
Expand Down