This repository has been archived by the owner on Jul 19, 2022. It is now read-only.
Pin open definitions to hash on perspective change #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there's any number of definitions open and a new perspective is selected, the definitions that were open with references based on names, will no longer have a resolvable name if they were to be re-queried (on a page refresh for instance). Fix this by changing all open definitions to be referenced by hash when the perspective is changed.
hojberg
force-pushed
the
permalinks-for-changing-perspective
branch
from
bb76e99
to
0fe8d70
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When there's any number of definitions open and a new perspective is
selected, the definitions that were open with references based on names,
will no longer have a resolvable name if they were to be re-queried (on
a page refresh for instance). Fix this by changing all open definitions
to be referenced by hash when the perspective is changed.
Fixes #270