Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: expose useStorage with types #1026

Merged
merged 3 commits into from
Mar 6, 2023
Merged

fix: expose useStorage with types #1026

merged 3 commits into from
Mar 6, 2023

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Mar 6, 2023

πŸ”— Linked issue

nuxt/nuxt#19148

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Expose useStorage types with runtime implementation outside of vfs.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codecov
Copy link

codecov bot commented Mar 6, 2023

Codecov Report

Merging #1026 (5e8af85) into main (d2b34e0) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1026      +/-   ##
==========================================
- Coverage   67.64%   67.59%   -0.05%     
==========================================
  Files          62       62              
  Lines        6267     6259       -8     
  Branches      707      707              
==========================================
- Hits         4239     4231       -8     
  Misses       2015     2015              
  Partials       13       13              
Impacted Files Coverage Ξ”
src/rollup/plugins/storage.ts 98.63% <100.00%> (-0.14%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks perfect πŸ‘Œ

@pi0 pi0 merged commit b495675 into main Mar 6, 2023
@pi0 pi0 deleted the fix/expose-use-storage branch March 6, 2023 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants